Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression improvements #207

Closed
wants to merge 4 commits into from
Closed

Conversation

bmwiedemann
Copy link

one bugfix
and three commits that help to get closer to identical compressed files after applying deltas

to omit the timestamp and thus produce reproducible compression output
which has a chance to match the original
this can help to get closer to identical files
after applying deltas
@jmacd
Copy link
Owner

jmacd commented Oct 7, 2015

I'd like to stall this for a moment.

There's a licensing question:
I am currently planning to re-license the Xdelta code base in the public
domain.
There's a minor complication, and I need to speak with my attorney.
I don't want to worry about CLAs and such, and I just need to make sure I'm
not making mistakes.

The change looks good.
Josh

On Sun, Oct 4, 2015 at 9:56 AM, Bernhard M. Wiedemann <
[email protected]> wrote:

one bugfix
and three commits that help to get closer to identical compressed files

after applying deltas

You can view, comment on, or merge this pull request online at:

#207
Commit Summary

  • xz magic is actually 6 bytes long
  • use gzip -n option for compression
  • add compression-level detection logic
  • detect xz, bz2 and gz compression level

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#207.

@bmwiedemann
Copy link
Author

I happen to know a bit about open-source licensing and remember that for example there is no public-domain in Germany, so licensing under the CC0 license ( https://creativecommons.org/publicdomain/zero/1.0/ ) would be the closest you could get. But for some reason few people do that for code and rather chose the MIT, X11 or BSD (2- or 3-clause) license if they wanted to be very permissive or GPLv2 or GPLv3+ if they want other people to contribute back.

@bmwiedemann
Copy link
Author

any update on this?

@jmacd jmacd closed this Feb 25, 2016
@jmacd
Copy link
Owner

jmacd commented Apr 17, 2016

Hi,
Sorry I broke this pull request, but I did make a change in the license and now I'm trying to find the time to properly release and announce it. After some research, I chose to use APLv2.
The branches are
https://github.com/jmacd/xdelta/tree/release3_1_apl
https://github.com/jmacd/xdelta/tree/release3_0_apl
Josh

@bmwiedemann
Copy link
Author

I rebased my branch ontop of your release3_0_apl branch. Want to re-open this PR or should I open a new one?

@bmwiedemann
Copy link
Author

moved to #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants